Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bucket: Set state of status prober properly #2120

Merged
merged 3 commits into from
Feb 11, 2020
Merged

bucket: Set state of status prober properly #2120

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6e750ee
Set state of status prober proberly
kakkoyun Feb 11, 2020
0a4e93c
Add bucket web to quickstart script
kakkoyun Feb 11, 2020
f26b584
Add changelog
kakkoyun Feb 11, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ We use *breaking* word for marking changes that are not backward compatible (rel

- [#2015](https://github.com/thanos-io/thanos/pull/2015) Sidecar: Querier /api/v1/series bug fixed when time range was ignored inside sidecar.
The bug was noticeable for example when using Grafana template variables.
- [#2120](https://github.com/thanos-io/thanos/pull/2120) Bucket Web: Set state of status prober properly.

## [v0.10.0](https://github.com/thanos-io/thanos/releases/tag/v0.10.0) - 2020.01.13

Expand Down
2 changes: 2 additions & 0 deletions cmd/thanos/bucket.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -355,6 +355,8 @@ func registerBucketWeb(m map[string]setupFunc, root *kingpin.CmdClause, name str
}

g.Add(func() error {
statusProber.Ready()

return refresh(ctx, logger, bucketUI, *interval, *timeout, name, reg, objStoreConfig)
}, func(error) {
cancel()
Expand Down
11 changes: 11 additions & 0 deletions scripts/quickstart.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,4 +212,15 @@ for i in $(seq 0 1); do
${STORES} &
done

sleep 0.5

if [ -n "${GCS_BUCKET}" -o -n "${S3_ENDPOINT}" ]; then
${THANOS_EXECUTABLE} bucket web \
--debug.name bucket-web \
--log.level debug \
--http-address 0.0.0.0:10933 \
--http-grace-period 1s \
${OBJSTORECFG} &
fi

wait