Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sampling for Elastic APM tracing #2039

Closed
igorwwwwwwwwwwwwwwwwwwww opened this issue Jan 24, 2020 · 0 comments
Closed

Sampling for Elastic APM tracing #2039

igorwwwwwwwwwwwwwwwwwwww opened this issue Jan 24, 2020 · 0 comments

Comments

@igorwwwwwwwwwwwwwwwwwwww
Copy link
Contributor

This may change with the switch to OpenTelemetry (#1972).

It looks like the Elastic APM tracing backend in thanos does not currently support sampling. Without sampling, every request will be traced, which can be quite expensive.

The Elastic APM client library does support sampling via Tracer.SetSampler, so adding support for that might not be that hard.
igorwwwwwwwwwwwwwwwwwwww added a commit to igorwwwwwwwwwwwwwwwwwwww/thanos that referenced this issue Jan 27, 2020
@igorwwwwwwwwwwwwwwwwwwww
support sampling on Elastic APM tracing
e6a5b8c 
fixes thanos-io#2039
Merged
2 tasks
igorwwwwwwwwwwwwwwwwwwww added a commit to igorwwwwwwwwwwwwwwwwwwww/thanos that referenced this issue Jan 27, 2020
@igorwwwwwwwwwwwwwwwwwwww
support sampling on Elastic APM tracing
40eb3b8 
fixes thanos-io#2039

Signed-off-by: Igor Wiedler <iwiedler@gitlab.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@igorwwwwwwwwwwwwwwwwwwww