s3: add DisableDualstack to config #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
narqo
force-pushed
the
add-s3-disable-dualstack
branch
from
49171f3 to
bc52f1f
Compare
narqo
commented
Mar 11, 2024
| @@ -1,6 +1,6 @@ | |||
| module github.com/thanos-io/objstore | |||
|
|
|||
| go 1.20 | |||
| go 1.21 | |||
There was a problem hiding this comment.
Note, this one comes from latest minio-go/v7, which is not ideal, but shouldn't be a big deal
go: github.com/minio/minio-go/v7@v7.0.69 requires go@1.21, but 1.20 is requested
bc52f1f to
994b458
Compare
Signed-off-by: Vladimir Varankin <vladimir@varank.in>
Signed-off-by: Vladimir Varankin <vladimir@varank.in>
narqo
force-pushed
the
add-s3-disable-dualstack
branch
from
8789bf6 to
f66bb0e
Compare
|
@matej-g could you have a glance over the latest changes. Is there anything I can do to help with landing them to mainline? |
Signed-off-by: Matej Gera <38492574+matej-g@users.noreply.github.com>
2 tasks
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Relates to grafana/mimir#7382.
Due to internal policies, enterprises deploy VPC Interface Endpoints with Private DNS option, which overrides
s3.region.amazonaws.com, pointing it to the local endpoint. Because S3 VPC Endpoints do not support dualstack, this adds extra requirements to the infrastructure (refer to minio/minio-go#1766 (comment) for details).This PR adds a new configuration to
s3client, allowing to disable the client from using AWS S3 dual-stack endpoints.