Add functions to implement Thanos Receive split functionality #244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bill3tt
force-pushed
the
receiver-split
branch
5 times, most recently
from
190d606
to
9b963c2
Compare
bill3tt
changed the title
bill3tt
changed the title
Signed-off-by: Ian Billett <ibillett@redhat.com>
Signed-off-by: Ian Billett <ibillett@redhat.com>
Signed-off-by: Ian Billett <ibillett@redhat.com>
bill3tt
force-pushed
the
receiver-split
branch
from
123fe1b
to
efa90f5
Compare
kakkoyun
requested changes
Aug 30, 2021
Signed-off-by: Ian Billett <ibillett@redhat.com>
Signed-off-by: Ian Billett <ibillett@redhat.com>
|
Thanks for your speedy review @kakkoyun 🙌 I think I've addressed all the comments :) |
bill3tt
changed the title
bill3tt
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the Thanos Receive split functionality in kube-thanos.
Changes
Fixes #229
This PR adds a two new helper functions
receiveRouterandreceiveIngestorto thethanos.libsonnetlibrary to implement the Thanos Receive split functionality.NB: This was the first time I have properly used Jsonnet - and I had a horrible time. Therefore I've almost certainly broken unwritten rules and are generally holding it wrong. Please help correct anything that is egregiously wrong
Verification
example.jsonnetto a local kind cluster.