Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BREAKING Change] Single ServiceMonitor for store shards #188

Merged
merged 1 commit into from
Jan 25, 2021

Commits on Jan 15, 2021

  1. Single ServiceMonitor for store shards

    The Prometheus operator creates 1 job per endpoint on each
    ServiceMonitor object it discovers. When using the thanos-store hashmod
    sharding feature of kube-thanos, 1 ServiceMonitor was created per store
    shard.  This resulted in 1 prometheus job per shard, with names like
    "thanos-store-0", "thanos-store-1".
    
    This commit changes this behavior to instead create only 1
    ServiceMonitor, with a Service label selector that selects all Services
    for the shards.
    
    Signed-off-by: Craig Furman <craig.furman89@gmail.com>
    craigfurman committed Jan 15, 2021
    Configuration menu
    Copy the full SHA
    17a8138 View commit details
    Browse the repository at this point in the history