Skip to content

Commit

Permalink
Filter out keys instead of hiding them
Browse files Browse the repository at this point in the history
Signed-off-by: Maxime Brunet <maxime.brunet@paytm.com>
  • Loading branch information
maxbrunet committed Jul 20, 2021
1 parent b745b8a commit 0a5a829
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 5 deletions.
1 change: 0 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@ We use *breaking* word for marking changes that are not backward compatible (rel

### Changed
- [#226](https://github.com/thanos-io/kube-thanos/pull/226) Only schedule thanos components on linux nodes.
- [#234](https://github.com/thanos-io/kube-thanos/pull/234) receive-hashrings/store-shards: Hide non-resource fields (`hashrings`/`shards`)

### Added
- [#228](https://github.com/thanos-io/kube-thanos/pull/228) Allow configuring `--web.prefix-header` of query.
Expand Down
4 changes: 2 additions & 2 deletions all.jsonnet
Original file line number Diff line number Diff line change
Expand Up @@ -226,5 +226,5 @@ local finalQ = t.query(q.config {
for name in std.objectFields(strs.shards[shard])
if strs.shards[shard][name] != null
} +
{ ['thanos-receive-hashrings-' + name]: rcvs[name] for name in std.objectFields(rcvs) if rcvs[name] != null } +
{ ['thanos-store-shards-' + name]: strs[name] for name in std.objectFields(strs) if strs[name] != null }
{ ['thanos-receive-hashrings-' + name]: rcvs[name] for name in std.objectFields(rcvs) if name != 'hashrings' && rcvs[name] != null } +
{ ['thanos-store-shards-' + name]: strs[name] for name in std.objectFields(strs) if name != 'shards' && strs[name] != null }
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ function(params)
labels: config.commonLabels,
},
},
hashrings:: {
hashrings: {
[h.hashring]: receive(config {
name+: '-' + h.hashring,
commonLabels+:: {
Expand Down
2 changes: 1 addition & 1 deletion jsonnet/kube-thanos/kube-thanos-store-shards.libsonnet
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ function(params)
},
},

shards:: {
shards: {
['shard' + i]: store(config {
name+: '-%d' % i,
commonLabels+:: { 'store.thanos.io/shard': 'shard-' + i },
Expand Down

0 comments on commit 0a5a829

Please sign in to comment.