Issues #1 #104
Open
Issues #1 #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Thomas Graf <tgraf@suug.ch>
Signed-off-by: Thomas Graf <tgraf@suug.ch>
Signed-off-by: Thomas Graf <tgraf@suug.ch>
Signed-off-by: Thomas Graf <tgraf@suug.ch>
Signed-off-by: Thomas Graf <tgraf@suug.ch>
Signed-off-by: Thomas Graf <tgraf@suug.ch>
Signed-off-by: Thomas Graf <tgraf@suug.ch>
Signed-off-by: Thomas Graf <tgraf@suug.ch>
Signed-off-by: Thomas Graf <tgraf@suug.ch>
Reported-by: Eric Leblond Signed-off-by: Thomas Graf <tgraf@suug.ch>
build: uclinux is also linux
Signed-off-by: Thomas Graf <tgraf@suug.ch>
Signed-off-by: Thomas Graf <tgraf@suug.ch>
Including: - MTU - Metric - RX/TX IRQ Quota Signed-off-by: Thomas Graf <tgraf@suug.ch>
debian installation procedures
make and build-essential package
Debian / Ubuntu Installation Procedures
…uld use `cfg_setbool` instead
assertion failed in libConfuse
Reported-by: DavidRChristensen Signed-off-by: Thomas Graf <tgraf@suug.ch>
Reported-by: DavidRChristensen Signed-off-by: Thomas Graf <tgraf@suug.ch>
When compiling bmon with the Linaro 2014.01 ARM toolchain (gcc-linaro-arm-linux-gnueabihf-4.8-2014.01_linux) the following compile error occurs: in_netlink.c: In function ‘do_link’: in_netlink.c:688:53: error: ‘IFF_UP’ undeclared (first use in this function) Fix it by explicitly including linux/if.h, where IFF_UP is defined. Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
[v2] Explicitly include linux/if.h to fix cross-compile error
Fix wrong unit displayed when using "--use-bit" option
Reported-by: Ross Patterson Signed-off-by: Thomas Graf <tgraf@suug.ch>
Signed-off-by: Thomas Graf <tgraf@suug.ch>
Signed-off-by: Thomas Graf <tgraf@suug.ch>
So far, any output module with a selection capability defaulted to the first interface in the list as first pick. This uses the policy configuration instead and thus allows to select which interface to display first: Examples: bmon -p 'em1,*' bmon -p 'eth*,lo,*' The first rule that finds a matching interface is used and will trigger initial selection. Note that this is *ONLY* evaluated after the first read of the statistics so if a more preferred interface appears later, the selection will not be changed. Signed-off-by: Thomas Graf <tgraf@suug.ch>
Signed-off-by: Thomas Graf <tgraf@suug.ch>
Signed-off-by: Thomas Graf <tgraf@suug.ch>
If the element currently selected is removed due to inactivity, the selection is fixed up to the previous element in the list. This step must be done after the entire element subgroup has been removed. Signed-off-by: Thomas Graf <tgraf@suug.ch>
Fix issue #43
…n is clear, it is nice to see an example to get started. Single quotes are used to prevent the shell from running our bmon patterns as commands, and to prevent it from doing wildcard expansion for the interface string.
…e shell from running our provided format placeholders.
…hile this is less pretty than it was before, it allows the user to actually paste the format string directly into their bmon command to try it out. Before this change, the way the string was formatted you could not simply paste it in and run it (whether it had single or double quotes).
Added example to man page, switched format strings to single quotes.
…ows us to redirect ascii based output to a file.
Flushed stdout after every group is printed in an iteration.
Using a realtime clock is a bad idea: it is affected by any kind of time change, which can happen when the administrator modifies the system time, or more simply when a laptop suspends to RAM and then wakes up from sleep. With the current approach of using a realtime clock: - if the system time jumps forward (e.g. when resuming after a suspend-to-RAM), bmon would take 100% CPU and display random graph data extremely fast, until it "catches up" with the new time. - if the system time jumps backwards, bmon would freeze until *time* "catches up" to the point it was before. bmon then (incorrectly) displays a spike in the graph, because lots of packets have been sent/received since the last update. Instead of using gettimeofday(), switch to clock_gettime() with CLOCK_MONOTONIC on systems that support it. OS X does not provide clock_gettime(), so this commit also adds a Mach-specific implementation. This change has been tested on Linux 4.1 with glibc and musl, and on FreeBSD 10.0-RELEASE-p12.
Use a monotonic clock instead of a realtime clock
Works on my CentOS 6.8 box
Added CentOS installation steps
Hook up the device rx nohandler stat counter available in the upcoming
libnl 3.2.29, added in libnl commit 5040fc8a4994 ("lib/route: add
rx_nohandler link stats field").
Also add a compatibility define, so older libnl version will still work
fine.
Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
Signed-off-by: Thomas Graf <tgraf@suug.ch>
In put_line(), replace the fixed onstack buffer with a xcalloc-ed buffer. This fixes a bmon crash with terminal size larger than 2048 bytes. The crash be reproduced with $ stty cols 2100 $ bmon .... Signed-off-by: Nachiketa Prachanda <nchkta@gmail.com>
The <values.h> header file is not present on Android, and the project builds there without it.
Signed-off-by: Thomas Graf <tgraf@suug.ch>
Fixes: #53 Signed-off-by: Thomas Graf <tgraf@suug.ch>
when section above or below is collapsed
|
Whoops, what happend here? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I need help reviewing my systems on my phone? Someone has access to all of my systems, how do I do it?