Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breakout Room 5: Update main.py #15

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Breakout Room 5: Update main.py #15

wants to merge 1 commit into from

Conversation

tgoslee
Copy link
Owner

@tgoslee tgoslee commented May 10, 2022

No description provided.

Copy link
Collaborator

@lili4x4 lili4x4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments on refactoring and requirements

@@ -1 +1,23 @@
#Mad Libs Generator Project
//Loop back to this point once code finishes
loop = 1
while (loop < 9):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This while loop would not loop the required times (10). Consider using a for loop instead since we know how many times we want to iterate.

@@ -1 +1,23 @@
#Mad Libs Generator Project
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider making this a function, maybe with helper functions to gather user input and print out the story.

Comment on lines +5 to +11
// All the questions that the program asks the user
noun = input("Choose a noun: ")
plural_noun = input("Choose a plural noun: ")
second_noun = input("Choose a noun: ")
place = input("Name a place: ")
adjective = input("Choose an adjective (Describing word): ")
third_noun = input("Choose a noun: ")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job including all the required inputs! I like how you worded the input statements for the user.

print ("Well it is.")
print ("------------------------------------------")
// Loop back to "loop = 1"
loop = loop + 1

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider adding some unit tests to ensure the code works as expected.

@@ -1 +1,23 @@
#Mad Libs Generator Project
//Loop back to this point once code finishes

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't commented out. Comment this correct with #

// Displays the story based on the users input
print ("------------------------------------------")
print ("Be kind to your",noun,"- footed", plural_noun)
print ("For a duck may be somebody's", seond_noun,",")

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

second_noun is misspelled.

Comment on lines +12 to +23
// Displays the story based on the users input
print ("------------------------------------------")
print ("Be kind to your",noun,"- footed", plural_noun)
print ("For a duck may be somebody's", seond_noun,",")
print ("Be kind to your",plural_noun,"in",place)
print ("Where the weather is always",adjective,".")
print ()
print ("You may think that is this the",third_noun,",")
print ("Well it is.")
print ("------------------------------------------")
// Loop back to "loop = 1"
loop = loop + 1

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Punctuation is not properly spaced through out the text. Consider using an f string. You may also want to consider using \n to create a multi-line string.
Also review the text on line 19.

Please review entire text for grammatical correctness.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants