Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DataTemplateSelectors in GraphControl #52

Closed

Conversation

KingKnecht
Copy link

Added ElementItemDataTemplateSelector and ConnectionItemDataTemplateSelector dependency properties to be able to use a DataTemplateSelector for different appearances of nodes and connections in the GraphControl.

Don't know why it detects in ElementItemsControl.cs. I guess I did something wrong...

…elector dependency properties to the GraphControl to be able to use a template selector for different appearences of the "nodes".
@tgjones
Copy link
Owner

tgjones commented Sep 8, 2014

This looks like a nice addition, thank you. But it looks like you have different whitespace settings from Gemini, which is why it's detecting that the whole file has changed. Please could you send a new pull request with whitespace set to spaces, not tabs?

Also I think you're missing some changes to Generic.xaml, to actually use these new data template selectors?

@tgjones tgjones added the Feature label Sep 8, 2014
@tgjones tgjones added this to the 0.6.0 milestone Sep 8, 2014
tgjones pushed a commit that referenced this pull request Nov 12, 2014
Same as #52 by @KingKnecht, but without the additional whitespace
changes.
@tgjones
Copy link
Owner

tgjones commented Nov 12, 2014

I have copied these changes and committed them in e3bedb7. Sorry I couldn't merge this pull request, but it had too many unnecesssary whitespace changes.

@tgjones tgjones closed this Nov 12, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants