Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a deprecation message about a missing return type #21

Merged
merged 1 commit into from
Nov 10, 2021

Conversation

javiereguiluz
Copy link
Contributor

This fixes the following deprecation:

  1x: Method "Symfony\Component\Config\Definition\ConfigurationInterface::getConfigTreeBuilder()" might add "TreeBuilder" as a native return type declaration in the future. Do the same in implementation "HtmlSanitizer\Bundle\DependencyInjection\Configuration" now to avoid errors or add an explicit @return annotation to suppress this message.
    1x in AddUserCommandTest::testCreateUserNonInteractive from App\Tests\Command

which we found when upgrading Symfony Demo app to the upcoming Symfony 5.4. See symfony/demo#1268 (comment)

@tgalopin tgalopin merged commit dc33ec1 into tgalopin:master Nov 10, 2021
@tgalopin
Copy link
Owner

Thanks!

@javiereguiluz javiereguiluz deleted the patch-1 branch November 10, 2021 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants