-
-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend k8s plugin #77
Conversation
K8s upstream: Allow setting the username for target
Update import to refer SaturnCloud fork
Check value for mappedUser and lexically store it instead of replacing outter value as it is a loop over a list of users, and it needs to be able to reuse mapped username if defined.
Update gomod lib ref
Proper checking username on targetHost
better to add e2e test for k8s. maybe by using minikube |
@tg123 did you mean as part of this PR? I think it is a good idea indeed, but not strictly related in here since this plugin already exists without it, then it would be a follow up. |
not required for this pr for sure, but nice to have. but i am still looking into the changes |
Yeah. It is probably due the dep on sshpipe-k8s-lib that is currently pinned in here as |
@tg123 Resolved conflicts.
If you then please approve the related PR and tag the v0.0.5, the build should be good to go. |
This proposes adding support for pubkey authentication.