Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend k8s plugin #77

Closed
wants to merge 14 commits into from
Closed

Extend k8s plugin #77

wants to merge 14 commits into from

Conversation

wreis
Copy link

@wreis wreis commented Sep 20, 2021

This proposes adding support for pubkey authentication.

@tg123
Copy link
Owner

tg123 commented Sep 21, 2021

better to add e2e test for k8s. maybe by using minikube

@wreis
Copy link
Author

wreis commented Sep 21, 2021

@tg123 did you mean as part of this PR? I think it is a good idea indeed, but not strictly related in here since this plugin already exists without it, then it would be a follow up.

@tg123
Copy link
Owner

tg123 commented Sep 21, 2021

@tg123 did you mean as part of this PR? I think it is a good idea indeed, but not strictly related in here since this plugin already exists without it, then it would be a follow up.

not required for this pr for sure, but nice to have.
build failed due to missing go package

but i am still looking into the changes

@wreis
Copy link
Author

wreis commented Sep 21, 2021

build failed due to missing go package

Yeah. It is probably due the dep on sshpipe-k8s-lib that is currently pinned in here as v.0.0.5 and that tag does not exist yet there.

@wreis
Copy link
Author

wreis commented Nov 23, 2021

@tg123 Resolved conflicts.

Yeah. It is probably due the dep on sshpipe-k8s-lib that is currently pinned in here as v.0.0.5 and that tag does not exist yet there.

If you then please approve the related PR and tag the v0.0.5, the build should be good to go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants