Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not grep recursively for min-required #237

Merged
merged 2 commits into from
Feb 6, 2021
Merged

Conversation

Zordrak
Copy link
Collaborator

@Zordrak Zordrak commented Feb 6, 2021

Resolve #225 by not inappropriately searching subdirectories of the root module for required_version.

As per #225:

If your root module is calling another module with a higher required minimum version, then your root module implicitly requires that version and should have its minimum version set accordingly. tfenv is not in a position to determine the minimum version of all possible module sources, whether stored locally on disk, within the same directory as the root component or elsewhere, or stored in an external git repository or registry. It can only depend on the root module informing as to the minimum version necessary for all dependent modules.

@Zordrak Zordrak self-assigned this Feb 6, 2021
@Zordrak Zordrak merged commit 44a68eb into master Feb 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

min-required not correct for base with sub-modules
1 participant