Fix bug on MacOS when using CLICOLOR=1 #152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amontalban
force-pushed
the
fix_ls_macos
branch
from
1a4a5b7
to
39f9f95
Compare
|
Testing a fix to conflicts |
Zordrak
approved these changes
May 27, 2020
Zordrak
approved these changes
May 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found a bug when trying to use
tfenvwith the env variableCLICOLOR=1to givelsthe ability to show colors in MacOS Terminal.The whole log can be found in https://gist.github.com/amontalban/380c68b99491577cf042d9ee9560f395.
What I did was changing the
lscommands withfinddoing it in a compatible way between GNU and no GNUfindbecause we can't use the-depthoption.Additionally I added recent versions of Ubuntu and MacOS for TravisCI testing, as well as putting
CLICOLORin the env to make sure it covers future cases.