Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issue #314 - include information about view/serializer in warnings #327

Merged

Commits on Mar 8, 2021

  1. Fixed issue tfranzel#314 - include information about view/serializer …

    …in warnings.
    
    The main technique for doing this in deeply nested places from which we call
    `error()` or `warn()`, is to a stack of traces that get added as prefices to the
    message (rather than having to pass this context information through many layers
    of code).
    
    This also fixes a set of consistency issues with warning/error messages:
    
    - Always start message with `{serializer/view name}: ` if possible.
      This meant removing this info from the body of the message
      where we are now adding it as a prefix.
    - First sentence shouldn't have a capital letter
      (the message is printed after colon from the prefix)
    - Subsequent sentences should have a capital letter.
    spookylukey committed Mar 8, 2021
    Configuration menu
    Copy the full SHA
    52b1c88 View commit details
    Browse the repository at this point in the history