-
Notifications
You must be signed in to change notification settings - Fork 260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Enum collision with same choices & varying labels #790 #1104 #1113
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1113 +/- ##
=======================================
Coverage 98.61% 98.62%
=======================================
Files 70 70
Lines 8506 8555 +49
=======================================
+ Hits 8388 8437 +49
Misses 118 118 ☔ View full report in Codecov by Sentry. |
908160c
to
7cc36f0
Compare
7cc36f0
to
dc73fc0
Compare
@tfranzel After upgrading, our schema is now full of these hashes. Shouldn't they be removed after schema is generated ? |
Aha, we have overridden |
I assume you are not using the default hook? drf-spectacular/drf_spectacular/hooks.py Line 14 in 9926bba
please add drf-spectacular/drf_spectacular/hooks.py Line 176 in 9926bba
to you postprocessing hooks (at the end). The new hook is already part of |
…VERRIDES` under `SPECTACULAR_SETTINGS` to ensure compatibility with drf-spectacular 0.27.0 and newer versions. That avoids the warnings about enum name collisions after drf-spectacular started differentiating between the 2 in tfranzel/drf-spectacular#1113 fixes #53
No description provided.