Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workflows cleaned and renamed appropriately. #11

Merged
merged 2 commits into from
Sep 30, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
name: build-windows
name: cygwin
on: [push, workflow_dispatch]
defaults:
run:
Expand All @@ -18,10 +18,9 @@ jobs:
- uses: actions/checkout@v4
- uses: cygwin/cygwin-install-action@v4
with:
packages: cmake gcc-core gcc-g++ make pkg-config
packages: cmake gcc-core make pkg-config
- run: ./run.sh
- run: cd tests && make && ./tests
- run: cd benchmarks && make && ./benchmarks
python:
name: windows-2022 / Python
runs-on: windows-2022
Expand All @@ -32,4 +31,3 @@ jobs:
packages: gcc-core python3 python3-devel python3-pip
- run: python3 -m pip install .
- run: python3 examples/Python/thread-safe.py
- run: python3 benchmarks/benchmarks.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
name: build-unix
name: unix
on: [push, workflow_dispatch]
env:
LD_LIBRARY_PATH: /usr/local/lib
Expand All @@ -15,7 +15,6 @@ jobs:
- uses: actions/checkout@v4
- run: ./run.sh
- run: cd tests && make && ./tests
- run: cd benchmarks && make && ./benchmarks
python:
name: ${{ matrix.os }} / Python
runs-on: ${{ matrix.os }}
Expand All @@ -26,4 +25,3 @@ jobs:
- uses: actions/checkout@v4
- run: python3 -m pip install .
- run: python3 examples/Python/thread-safe.py
- run: python3 benchmarks/benchmarks.py
10 changes: 8 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,14 @@ On Windows, these are available natively via [MSYS2](https://www.msys2.org) (not
[Homebrew](https://brew.sh); however, their Apple-specific variants provided by
[Xcode](https://apps.apple.com/app/xcode/id497799835) should also be fine.

![build-unix](https://github.com/tfpf/hash-drbg/actions/workflows/build-unix.yml/badge.svg)
![build-windows](https://github.com/tfpf/hash-drbg/actions/workflows/build-windows.yml/badge.svg)
## Troubleshooting Information
Installing directly on Windows is a massive headache. MSVC adds some unnecessary flags which are incompatible with
optimisation flags, so the program does not compile. Its concurrency library doesn't properly implement atomic data
types, and isn't standard-compliant. Further, Windows does not provide a random device. That is why I suggest MSYS2 and
Cygwin. If installation fails for you, check the [workflows](.github/workflows) to see how I got it working.

![cygwin](https://github.com/tfpf/hash-drbg/actions/workflows/cygwin.yml/badge.svg)
![unix](https://github.com/tfpf/hash-drbg/actions/workflows/unix.yml/badge.svg)

## Install for C (and C++)
```shell
Expand Down