Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Wheel version for macOS BigSur issues #965

Merged
merged 1 commit into from
Mar 18, 2022
Merged

Bump Wheel version for macOS BigSur issues #965

merged 1 commit into from
Mar 18, 2022

Conversation

ChrisFriesen
Copy link
Contributor

To deal with this issue pypa/wheel#385 where Mac has changed the versioning of its OS and it's breaking a previous assertion statement

Copy link
Contributor

@kkloberdanz kkloberdanz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, so long as CI passes 👍

Copy link
Member

@mortendahl mortendahl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Did you try locally? We're not running as many checks on Python in CI as we'd like.

@mortendahl
Copy link
Member

mortendahl commented Mar 17, 2022

so long as CI passes

That's the problem, this may not be enough for Python related PR! 😬 Although I do think the checks on main include Python; you just won't know until it's merged.

@ChrisFriesen
Copy link
Contributor Author

I've built it locally and am leveraging it through transcriber right now using the whl file. Short tests pass but the long test fails with an expected error ticketed here #692. Let me know if there's anything else I should check.

@mortendahl
Copy link
Member

Short tests pass but the long test fails with an expected error ticketed here #692.

@jvmncs should we simply merge?

@jvmncs
Copy link
Member

jvmncs commented Mar 18, 2022

Yes 🙂

@jvmncs jvmncs merged commit 4ef77fc into main Mar 18, 2022
@jvmncs jvmncs deleted the chris/bump-wheel branch March 18, 2022 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants