Migrate from tzstats to tzpro

[jdsika]

• Check list:

• I extended the Github Actions CI test units with the corresponding tests for this new feature (if needed).
• I extended the Sphinx documentation (if needed).
• I extended the help section (if needed).
• I changed the README file (if needed).
• I created a new issue if there is further work left to be done (if needed).

Work effort: 6h

[Nikolay-everstake]

Yep it works for us. Thank you.

[vkresch]

Any reasons for this migration?
Can't we just extend the API with tzpro instead of replacing tzstats with it or is tzstat going to be deprecated?
Please provide some context in the description. Thanks!

Update tzstats going to be deprecated:

TzStats API EOL @ Oct 31, 2023
Attention TzStats API users

We are migrating all RPC and API services to our new TzPro service. Visit https://tzpro.io/ and sign up for free to get your personal API key.

All API data and endpoints will remain available and free on TzPro up to 100,000 req/mon.

https://tzstats.com/

[jdsika]

It was deprecated and replaced. Here is the migration guide. Tzstats does not exist anymore:

https://blockwatch.cc/blog/migrating-to-tzpro/

[vkresch]

Ok got it. Thanks for the context.

[jdsika]

I tired to catch absolutely every occurance of tzstats and also renamed the folder to blockwatch (the company behind it) in order to pave the way to include new API Interfaces later (if needed)

[vkresch]

How about we add the api key to the command line when using tzpro instead of forcing the user to create a .env file? We are currently not using envríronmental variables anywhere in the project.

[vkresch]

We might wanna setup then a test api key for our test pipeline. For that we might use the secrets manager of github actions.

[ericlavoie]

We have a config file, we put api for twitter and other in it, why not use it. Why spread the config.

[vkresch]

Even better :)

[vkresch]

@jdsika can I push commits on this PR?

[jdsika]

@jdsika can I push commits on this PR?

yes, please! I am on erics side to put it in the config. I did not think about (stupid)

[vkresch]

Not ready yet. I am fixing the tests now. DO NOT MERGE!

[vkresch]

There are still some failing tests due to API updates which needs further investigation and is out of scope for this PR. I also noticed that the enum comparisons are not working correctly and I am not sure why. E.g. payment_item.paid == PaymentStatus.PAID is false but payment_item.paid.is_paid() is true. That's really confusing. Best way to compare enums would be to compare their values for now:
payment_item.paid.value == PaymentStatus.PAID.value

Currently failing tests:

• test_attempt_single_batch_tz
• test_attempt_single_batch_KT
• test_batch_payer_total_payout_amount
• test_simulate_single_operation
• test_failed_simulate_single_operation
• test_reset
• test_archive

Effort: 8h