Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix position to report in a certain cases #5

Merged
merged 1 commit into from
Jan 19, 2016

Conversation

orangain
Copy link
Contributor

Problem

When the second or later sentence in the paragraph contains many tens, the rule reports wrong position in some cases.

$ cat problematic_cases.md
複数のセンテンスがある場合。これでも、columnが、ちゃんと計算、されているはずです。

複数のセンテンスがあって、改行されている場合でも
大丈夫です。これでも、lineとcolumnが、ちゃんと計算、されているはずです。

Before

Reports wrong position.

$ textlint --rule max-ten problematic_cases.md

/private/tmp/problematic_cases.md
  1:20  error  一つの文で"、"を3つ以上使用しています  max-ten
  3:25  error  一つの文で"、"を3つ以上使用しています  max-ten

✖ 2 problems (2 errors, 0 warnings)

After

Reports correct position.

$ textlint --rule max-ten problematic_cases.md

/private/tmp/problematic_cases.md
  1:34  error  一つの文で"、"を3つ以上使用しています  max-ten
  4:31  error  一つの文で"、"を3つ以上使用しています  max-ten

✖ 2 problems (2 errors, 0 warnings)

@azu
Copy link
Member

azu commented Jan 19, 2016

@orangain Thanks! Nice catch!

azu added a commit that referenced this pull request Jan 19, 2016
fix: Fix position to report in multiple line case.
@azu azu merged commit 9014725 into textlint-ja:master Jan 19, 2016
@azu
Copy link
Member

azu commented Jan 19, 2016

publish 2.0.1

@orangain
Copy link
Contributor Author

Surprised at your quick merge and release. Thanks 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants