Change tokenize cache to prevent memory leak caused by inifinite cache #19
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
初めまして。
_tokensCacheMap
が無限にキャッシュしていくため、APIのような形式でプロセスを立ち上げたままにしておくと、どこかでheapが足りなくなると思います。
getTokenizer
ではなくtokenize
を使用すれば、LRUMapによる上限付きのキャッシュになるため、そちらに変更するPRです。何か間違いがあればご指摘ください。
ご確認よろしくお願いします。