jit: support unreachable instruciton, and stack trace. #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Takeshi Yoneda <takeshi@tetrate.io>
mathetake
commented
Dec 10, 2021
codefromthecrypt
approved these changes
Dec 10, 2021
| (call $three) | ||
| ) | ||
| (func $three | ||
| (unreachable) |
There was a problem hiding this comment.
is there a more intuitive use of unreachable? like something where it is may occur in real life (not a forged example)
There was a problem hiding this comment.
for example unreachable will be placed in a branch for the case when the slice boundary check failed (like TinyGO does emit unreachable on "slice out of bounds")!
There was a problem hiding this comment.
But it is essentially the same as this example
Signed-off-by: Takeshi Yoneda <takeshi@tetrate.io>
Signed-off-by: Takeshi Yoneda <takeshi@tetrate.io>
|
thanks for making it possible to uhh become unreachable! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Takeshi Yoneda takeshi@tetrate.io
part of #65