Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wasi: env initialization fix #262

Merged
merged 2 commits into from
Feb 18, 2022
Merged

Conversation

pims
Copy link
Contributor

@pims pims commented Feb 18, 2022

Closes #261

Closes tetratelabs#261

Signed-off-by: tim <tim@pims.me>
wasi.go Outdated Show resolved Hide resolved
@codefromthecrypt codefromthecrypt merged commit 16f35f0 into tetratelabs:main Feb 18, 2022
@codefromthecrypt
Copy link
Contributor

Thanks for the help and sorry about the construction debris. We're trying to finish major api breaks this weekend.

@pims
Copy link
Contributor Author

pims commented Feb 19, 2022

Nothing to be sorry about! Was about to contribute Environment support but happy to see someone did it before me!

@pims pims deleted the pims/env-fix branch February 19, 2022 00:48
@codefromthecrypt
Copy link
Contributor

ps if you are using something besides tinygo and/or need a WASI API not defined here, please pipe up in the issue #271

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug in WASISnapshotPreview1WithConfig for Environment variables
2 participants