Adds host function interfaces #246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds two interfaces with only one implementation each, used to decouple end-user code from internals. * api.HostFunctionCallContext - allows access to go Context and Memory * api.Memory - read/write standard types and arbitrary data This currently ports existing code to use the interfaces. It is true that over time we can use structs instead of interfaces internally to save a pointer reference in WASI call sites. However, I'm choosing not to do this right now, as it is more important to see the interfaces work. We should defer optimizing towards structs until after we repackage implementations under the "internal" directory. Fixes #204 Signed-off-by: Adrian Cole <adrian@tetrate.io>
| // There are two result parameters: these are offsets in the wasm.HostFunctionCallContext Memory Buffer to write | ||
| // corresponding sizes in uint32 little-endian encoding. | ||
| // There are two result parameters: these are offsets in the api.HostFunctionCallContext Memory to write | ||
| // corresponding sizes in uint32 little-endian encoding. If either are invalid due to memory constraints, this |
There was a problem hiding this comment.
fyi @r8d8, this is the sort of comment I'm adding about errno choices. you can make one similarly, and if we need to change later we can update
If either are invalid due to memory constraints, this returns ErrnoFault.
mathetake
approved these changes
Feb 15, 2022
|
|
||
| // hasLen returns true if Len is sufficient for sizeInBytes at the given offset. | ||
| func (m *MemoryInstance) hasLen(offset uint32, sizeInBytes uint32) bool { | ||
| return uint64(offset+sizeInBytes) <= uint64(m.Len()) // uint64 prevents overflow on add |
mathetake
reviewed
Feb 15, 2022
api/host.go
Outdated
| @@ -0,0 +1,69 @@ | |||
| // Package api only includes constants and interfaces. This ensures no package cycles in implementation. | |||
There was a problem hiding this comment.
incidentally I think we can temporarily put this in the "wasm" package
There was a problem hiding this comment.
changed to wasm package for now as I think even with top-level entry points in the wazero package we'll still be able to keep packages for things like constants if we choose to. I'll show what I mean post-merge in #238
Co-authored-by: Takeshi Yoneda <takeshi@tetrate.io>
Signed-off-by: Adrian Cole <adrian@tetrate.io>
codefromthecrypt
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds two interfaces with only one implementation each, used to
decouple end-user code from internals.
This currently ports existing code to use the interfaces. It is true
that over time we can use structs instead of interfaces internally to
save a pointer reference in WASI call sites. However, I'm choosing not
to do this right now, as it is more important to see the interfaces
work. We should defer optimizing towards structs until after we
repackage implementations under the "internal" directory.
Fixes #204