Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: use Linux ARM runners. #2366

Merged
merged 4 commits into from
Jan 21, 2025
Merged

CI: use Linux ARM runners. #2366

merged 4 commits into from
Jan 21, 2025

Conversation

ncruces
Copy link
Collaborator

@ncruces ncruces commented Jan 17, 2025

Signed-off-by: Nuno Cruces <ncruces@users.noreply.github.com>
@ncruces ncruces changed the title Use Linux ARM runners. CI: use Linux ARM runners. Jan 17, 2025
Signed-off-by: Nuno Cruces <ncruces@users.noreply.github.com>
Signed-off-by: Nuno Cruces <ncruces@users.noreply.github.com>
@robherley
Copy link

@ncruces The new label is ubuntu-24.04-arm, I think there's a typo in the workflow definitions where you have *-arm64 and it's not matching any labels

@ncruces
Copy link
Collaborator Author

ncruces commented Jan 18, 2025

Nice catch. Just need to fix the DCO.

Signed-off-by: Nuno Cruces <ncruces@users.noreply.github.com>
@ncruces ncruces marked this pull request as ready for review January 19, 2025 00:31
@ncruces ncruces requested a review from mathetake as a code owner January 19, 2025 00:31
- os: ubuntu-22.04
arch: amd64
- os: ubuntu-22.04-arm
arch: arm64
Copy link
Contributor

@anuraaga anuraaga Jan 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we add to the normal test task too?

Another note is personally, running this for every arch seems like overkill. amd64 was added for #385, while arm64 was here because it required qemu. Now it doesn't require qemu, so I'm wondering if we need both amd64 and arm64 in this matrix.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah I would rather delete this for amd64 and arm64

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I used this because it's a “reduced” test suite compared to “full” (same way I used it for the VMs, although cross compilation helps there).

But I can drop this and run the full test suite on Linux ARM.

Or not at all (we stopped running any tests on macOS AMD64). I run a bunch of these other configurations (including BSD ARM) on my own repo, so it's not like it's untested.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so up to you but we want to reduce the CI costs

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well at least for this run, scratch+AMD was faster than base+AMD (and scratch+ARM is faster still).

I dunno what's cheaper by the minute?

If we wanna reduce costs we can drop some of the targets I added, or move them to something we manually run (e.g. before a release).

If we make them manually triggered I can at least run them for free on a fork, that's easy enough to do.

@mathetake mathetake merged commit 4231c48 into main Jan 21, 2025
50 checks passed
@mathetake mathetake deleted the arm-run branch January 21, 2025 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants