Fix path_symlink only works when dir mounted to / #2229
Merged
+46
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes `path_symlink` not working when `-mount` is not supplied with a mapped directory. fixes tetratelabs#2228 Signed-off-by: Yage Hu <me@huyage.dev>
mathetake
requested changes
Jun 5, 2024
Signed-off-by: Yage Hu <me@huyage.dev>
yagehu
commented
Jun 5, 2024
| @@ -4941,7 +4973,7 @@ func requireOpenFile(t *testing.T, tmpDir string, pathName string, data []byte, | |||
| if readOnly { | |||
| fsConfig = fsConfig.WithReadOnlyDirMount(tmpDir, "/") | |||
| } else { | |||
| fsConfig = fsConfig.WithDirMount(tmpDir, "/") | |||
| fsConfig = fsConfig.WithDirMount(tmpDir, "preopen") | |||
There was a problem hiding this comment.
This is necessary to expose the problem because the original path join would discard the /, masking the bug. Preopening a directory and mounting it at a non-root location would cause the bug.
mathetake
reviewed
Jun 5, 2024
Signed-off-by: Yage Hu <me@huyage.dev>
mathetake
reviewed
Jun 5, 2024
Signed-off-by: Yage Hu <me@huyage.dev>
mathetake
approved these changes
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes
path_symlinknot working when-mountis not supplied with a mapped directory.fixes #2228