Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sysfs: fix compile-time check on osFile #2100

Merged
merged 1 commit into from
Feb 27, 2024
Merged

Conversation

karelbilek
Copy link
Contributor

This is a tiny fix of a compile-time check on osFile.

It's not like it matters all that much, as the missing method would be caught in other layers anyway, but when the check is there, it should be correct :)

This is a tiny fix of a compile-time check on osFile.

It's not like it _matters_ all that much, as the missing method would be caught in other layers anyway, but when the check is there, it should be correct :)

Signed-off-by: Karel Bilek <kb@karelbilek.com>
@mathetake mathetake removed their request for review February 27, 2024 11:34
Copy link
Contributor

@evacchi evacchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ha! good eye!

@evacchi evacchi changed the title Tiny fix of compile-time check on osFile sysfs: fix compile-time check on osFile Feb 27, 2024
@evacchi evacchi merged commit ba56962 into tetratelabs:main Feb 27, 2024
67 checks passed
evacchi pushed a commit to evacchi/wazero that referenced this pull request Feb 28, 2024
Signed-off-by: Karel Bilek <kb@karelbilek.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants