Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fuzz: adds unaligned global f32 case #2040

Merged
merged 3 commits into from
Feb 12, 2024
Merged

fuzz: adds unaligned global f32 case #2040

merged 3 commits into from
Feb 12, 2024

Conversation

evacchi
Copy link
Contributor

@evacchi evacchi commented Feb 11, 2024 •
edited
Loading

fails consistently on amd64, but it won't crash rosetta2 on macOS/Arm
EDIT: and unfortunately it's not crashing qemu either...

evacchi@lima-amd64:/Users/evacchi/Devel/github.com/tetratelabs/wazero/internal/integration_test/fuzzcases$ ./fuzz.test -test.v -test.run Test2040
=== RUN   Test2040
--- PASS: Test2040 (0.00s)
PASS

@evacchi
wazevo(amd64). fuzz: sigsegv
200bcc1 
Signed-off-by: Edoardo Vacchi <evacchi@users.noreply.github.com>
@mathetake
Copy link
Member

Cool thanks... this is weird...

@evacchi
minimize further
86f2426 
Signed-off-by: Edoardo Vacchi <evacchi@users.noreply.github.com>
@mathetake
Copy link
Member

I will take this from here. I managed to reproduce with EPYC-v3 CPU on qemu.

@evacchi
Copy link
Contributor Author

evacchi commented Feb 11, 2024

oh cool!

@mathetake mathetake marked this pull request as ready for review February 11, 2024 23:56
@mathetake mathetake self-requested a review as a code owner February 11, 2024 23:56
@mathetake
Copy link
Member

#2042 temporarily allows passing this test case, but I will do the more fundamental fix later. anyway thank you for noticing this crash!

@mathetake mathetake changed the title wazevo(amd64). fuzz: sigsegv fuzz: adds unaligned global f32 case Feb 11, 2024
@mathetake mathetake merged commit 392dcf7 into main Feb 12, 2024
63 of 64 checks passed
@mathetake mathetake deleted the fuzz-crash branch February 12, 2024 00:06
evacchi added a commit to evacchi/wazero that referenced this pull request Feb 28, 2024
@evacchi @mathetake
fuzz: adds unaligned global f32 case (tetratelabs#2040)
6890512 
Signed-off-by: Edoardo Vacchi <evacchi@users.noreply.github.com>
Co-authored-by: Takeshi Yoneda <t.y.mathetake@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mathetake mathetake mathetake approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@evacchi @mathetake