Fix fd_fdstat_set_flags truncating with O_TRUNC
#1863
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yagehu
requested review from
codefromthecrypt,
mathetake and
evacchi
as code owners
yagehu
force-pushed
the
yagehu/false-trunc
branch
from
5df6ce6
to
0487f6a
Compare
This commit fixes a buf when `fd_fdstat_set_flags` would erroneously truncate an open file if it is opened with the O_TRUNC flag. This happens because the O_TRUNC flag causes the file to be truncated when it is opened. Signed-off-by: Yage Hu <me@huyage.dev>
yagehu
force-pushed
the
yagehu/false-trunc
branch
from
0487f6a
to
491279a
Compare
evacchi
approved these changes
Dec 12, 2023
gaukas
pushed a commit
to refraction-networking/wazero
that referenced
this pull request
Dec 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes a buf when
fd_fdstat_set_flagswould erroneously truncate an open file if it is opened with the O_TRUNC flag. This happens because the O_TRUNC flag causes the file to be truncated when it is opened.This fixes #1862