wazevo: fuzz, select does not return the correct value for vectors #1814
Conversation
evacchi
force-pushed
the
fuzz-select
branch
2 times, most recently
from
44e94b3
to
af44b37
Compare
Signed-off-by: Edoardo Vacchi <evacchi@users.noreply.github.com>
| ifNonZeroPos.begin, ifNonZeroPos.end = ifnzTgt, ifnzTgt | ||
| m.labelPositions[ifNonZero] = ifNonZeroPos |
There was a problem hiding this comment.
plz use insertBrTargetLabel instead to avoid these lines (none of other places directly modify labelPositions).
There was a problem hiding this comment.
I wanted to use insertBrTargetLabel() but isn't that only for jump backwards? it inserts a labeled nop immediately, while here I need to allocate a label, point to it in the condBr, and then insert the nop at the right spot.
There was a problem hiding this comment.
maybe I can just split insertBrTargetLabel() to 2 functions, with one taking a pre-declared label
There was a problem hiding this comment.
done, let me know if this is good.
There was a problem hiding this comment.
I'm going to sleep but I believe you should be able to achieve what you want without adding new change like that. Basically checking other places in the lower_instr would help
There was a problem hiding this comment.
oh I see, from a cursory look I didn't notice how you were doing it.
Signed-off-by: Edoardo Vacchi <evacchi@users.noreply.github.com>
Signed-off-by: Edoardo Vacchi <evacchi@users.noreply.github.com>
#1496