Use setup-go output for standard library test key #1711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anuraaga
requested review from
codefromthecrypt and
mathetake
as code owners
…rsion Signed-off-by: Anuraag Agrawal <anuraaga@gmail.com>
anuraaga
force-pushed
the
wazero-go-output
branch
from
4ee1b85
to
c24069e
Compare
mathetake
approved these changes
Sep 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows respecting patch version
Interestingly, it seems that based on the randomly selected runner, the go version can be different
https://github.com/tetratelabs/wazero/actions/runs/6180785720/job/16777777783?pr=1709
https://github.com/tetratelabs/wazero/actions/runs/6180785720/job/16778006464?pr=1709
One way to not have this happen is
check-latest. It's funny how they recommendfalsefor stability :Phttps://github.com/actions/setup-go#check-latest-version