wazevo: pass address.wast #1649
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com>
mathetake
force-pushed
the
wazevoaddress
branch
from
c555e7b
to
7f67ebf
Compare
mathetake
commented
Aug 22, 2023
Comment on lines
-191
to
+195
| if _, ok := info.defs[def]; ok { | ||
| // This must be a bug in lowering logic in the ISA-specific code. | ||
| // In short, a virtual register must be defined only once because that's the invariant of | ||
| // liveness analysis result used in the current implementation. If you reach here, you can either | ||
| // use "temporary" physical register (like x27 in AArch64), or simply allocate a new virtual | ||
| // register for the additional definition. In any ways, such a new virtual register doesn't cost | ||
| // at all in the final code because they are instantly killed and won't interfere with other | ||
| // virtual registers later on. | ||
| // | ||
| // TODO: this should be enforced globally, not just per block. But that can be costly to check. | ||
| panic(fmt.Sprintf("BUG: multiple definitions found for a virtual register %s", def.String())) | ||
| if _, ok := info.defs[def]; !ok { | ||
| // This means that this VReg is defined multiple times in a series of instructions | ||
| // e.g. loading arbitrary constant in arm64, and we only need the earliest | ||
| // definition to construct live range. | ||
| info.defs[def] = pos |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1496