Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds support for build on GOOS=js #1614

Merged
merged 2 commits into from
Aug 7, 2023
Merged

Adds support for build on GOOS=js #1614

merged 2 commits into from
Aug 7, 2023

Conversation

mathetake
Copy link
Member

@mathetake mathetake commented Aug 7, 2023 •
edited
Loading

Fixes:

$ GOOS=js GOARCH=wasm go build ./...
# github.com/tetratelabs/wazero/internal/sock
internal/sock/sock_supported.go:8:22: undefined: syscall.SHUT_RD
internal/sock/sock_supported.go:9:22: undefined: syscall.SHUT_RDWR
internal/sock/sock_supported.go:10:22: undefined: syscall.SHUT_WR

@mathetake
Adds support for build on GOOS=js
8d68b5a 
Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com>
@mathetake
reviews
0b5b6fe 
Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com>
@mathetake mathetake merged commit 2922b0e into main Aug 7, 2023
61 checks passed
@mathetake mathetake deleted the buildonjs branch August 7, 2023 05:59
jerbob92 pushed a commit to jerbob92/wazero that referenced this pull request Aug 9, 2023
@mathetake @jerbob92
Adds support for build on GOOS=js (tetratelabs#1614)
b679c98 
Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com>
Signed-off-by: Jeroen Bobbeldijk <jeroen@klippa.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@achille-roussel achille-roussel achille-roussel approved these changes

@codefromthecrypt codefromthecrypt Awaiting requested review from codefromthecrypt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mathetake @achille-roussel