sysfs: restore check for EINTR in poll test, fix Windows tests #1604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EINTR used to be ignored when `select` was used, but the check was deleted during the migration to `poll`, but this might make some tests flakier. Some time-based tests also seem flakier, so we try to make them slightly more robust. Signed-off-by: Edoardo Vacchi <evacchi@users.noreply.github.com>
evacchi
changed the title
evacchi
changed the title
codefromthecrypt
approved these changes
Jul 30, 2023
There was a problem hiding this comment.
I recall once us looping on EINTR internally, such as Go does in functions that call os.ignoringEINTR, for reasons including avoiding excess host calls. I wonder if that's appropriate in osFile or not for File.Poll? Such an adjustment can be now or later or never
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EINTR used to be ignored when
selectwas used, but the check wasdeleted during the migration to
poll: looks like this made some tests flaky.Some time-based tests for Windows also seem flakier, so we try to make them slightly more robust.
Fixes #1601
Signed-off-by: Edoardo Vacchi evacchi@users.noreply.github.com