Emulates AT_SYMLINK_NOFOLLOW instead of sometimes implementing it #1588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 21, 2023 14:19
futimes `AT_SYMLINK_NOFOLLOW` isn't universally supported. Before, we attempted to support it, but it was a bit hairy. It is better to take the hit of opening the file in the case we need to *not* follow symlinks than deal with something not very portable by default. Signed-off-by: Adrian Cole <adrian@tetrate.io>
| @@ -1456,7 +1456,16 @@ func pathFilestatSetTimesFn(_ context.Context, mod api.Module, params []uint64) | |||
| } | |||
|
|
|||
| symlinkFollow := flags&wasip1.LOOKUP_SYMLINK_FOLLOW != 0 | |||
There was a problem hiding this comment.
the flag is the opposite of the POSIX one in wasip1, presumably to avoid accidentally setting it by default.
| ) | ||
|
|
||
| //go:noescape | ||
| //go:linkname utimensat syscall.utimensat | ||
| func utimensat(dirfd int, path string, times *[2]syscall.Timespec, flags int) error | ||
|
|
||
| func utimens(path string, times *[2]syscall.Timespec, symlinkFollow bool) error { | ||
| func utimens(path string, times *[2]syscall.Timespec) error { |
There was a problem hiding this comment.
a later PR will switch this to os.Chtimes which is basically the same logic (once we remove the special OMIT and NOW constants)
evacchi
approved these changes
Jul 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
futimes
AT_SYMLINK_NOFOLLOWisn't universally supported. Before, we attempted to support it, but it was a bit hairy. It is better to take the hit of opening the file in the case we need to not follow symlinks than deal with something not very portable by default.