Terms and conditions error

[swainn]

Description

This PR addresses an issue with loading error templates when the middleware hasn't been processed.

The specific issue was caused by a missing host in ALLOWED_HOSTS, which would end up raising this error:

ERROR Invalid HTTP_HOST header: '127.0.0.1:8000'. You may need to add '127.0.0.1' to ALLOWED_HOSTS.
Traceback (most recent call last):
  File "/home/tethysdev/miniconda3/envs/tethys/lib/python3.12/site-packages/django/core/handlers/exception.py", line 55, in inner
    response = get_response(request)
               ^^^^^^^^^^^^^^^^^^^^^
  File "/home/tethysdev/miniconda3/envs/tethys/lib/python3.12/site-packages/django/utils/deprecation.py", line 128, in __call__
    response = self.process_request(request)
               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/tethysdev/miniconda3/envs/tethys/lib/python3.12/site-packages/django/middleware/common.py", line 48, in process_request
    host = request.get_host()
           ^^^^^^^^^^^^^^^^^^
  File "/home/tethysdev/miniconda3/envs/tethys/lib/python3.12/site-packages/django/http/request.py", line 151, in get_host
    raise DisallowedHost(msg)
django.core.exceptions.DisallowedHost: Invalid HTTP_HOST header: '127.0.0.1:8000'. You may need to add '127.0.0.1' to ALLOWED_HOSTS.
Exception inside application: 'ASGIRequest' object has no attribute 'user'
Traceback (most recent call last):
  File "/home/tethysdev/miniconda3/envs/tethys/lib/python3.12/site-packages/django/core/handlers/exception.py", line 55, in inner
    response = get_response(request)
               ^^^^^^^^^^^^^^^^^^^^^
  File "/home/tethysdev/miniconda3/envs/tethys/lib/python3.12/site-packages/django/utils/deprecation.py", line 128, in __call__
    response = self.process_request(request)
               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/tethysdev/miniconda3/envs/tethys/lib/python3.12/site-packages/django/middleware/common.py", line 48, in process_request
    host = request.get_host()
           ^^^^^^^^^^^^^^^^^^
  File "/home/tethysdev/miniconda3/envs/tethys/lib/python3.12/site-packages/django/http/request.py", line 151, in get_host
    raise DisallowedHost(msg)
django.core.exceptions.DisallowedHost: Invalid HTTP_HOST header: '127.0.0.1:8000'. You may need to add '127.0.0.1' to ALLOWED_HOSTS.

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/home/tethysdev/miniconda3/envs/tethys/lib/python3.12/site-packages/django/core/handlers/exception.py", line 164, in get_exception_response
    response = callback(request, exception=exception)
               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/tethysdev/tethys/tethys_portal/views/error.py", line 25, in handler_400
    return render(request, "tethys_portal/error.html", context, status=400)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/tethysdev/miniconda3/envs/tethys/lib/python3.12/site-packages/django/shortcuts.py", line 25, in render
    content = loader.render_to_string(template_name, context, request, using=using)
              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/tethysdev/miniconda3/envs/tethys/lib/python3.12/site-packages/django/template/loader.py", line 62, in render_to_string
    return template.render(context, request)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/tethysdev/miniconda3/envs/tethys/lib/python3.12/site-packages/django/template/backends/django.py", line 107, in render
    return self.template.render(context)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/tethysdev/miniconda3/envs/tethys/lib/python3.12/site-packages/django/template/base.py", line 169, in render
    with context.bind_template(self):
         ^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/tethysdev/miniconda3/envs/tethys/lib/python3.12/contextlib.py", line 137, in __enter__
    return next(self.gen)
           ^^^^^^^^^^^^^^
  File "/home/tethysdev/miniconda3/envs/tethys/lib/python3.12/site-packages/django/template/context.py", line 256, in bind_template
    context = processor(self.request)
              ^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/tethysdev/tethys/tethys_portal/context_processors.py", line 38, in tethys_portal_context
    or (request.user.is_authenticated and request.user.is_active)
        ^^^^^^^^^^^^
AttributeError: 'ASGIRequest' object has no attribute 'user'

<------------- AttributeError repeated 4-5 times ------------->

I suspect this was caused by the following chain of events:

• ALLOWED_HOST error was raised
• The error prevented the Middleware from running that adds the user to the request
• Django tried to load the 400 error page of Tethys
• The 400 page of Tethys inherits from base.html
• The base.html includes a template from terms and conditions
• Terms and conditions requires the user to be added to the request and raises an Attribute Error if it is not found.
• This causes Django to try to load the 500 error page which triggers the Terms and Conditions Attribute Error again
• It cycles a few more times and then dies

Changes Made to Code

• Added check for request.user in the if block that includes the TOS template in the base.html and app_base.html templates.
• Adds {% block tos_override %}{% endblock %} override to the error.html base template for the error pages, so terms and conditions is never loaded on the error pages.
• Add check for request.user to context processor that could cause similar issue

Related PRs, Issues, and Discussions

• N/A

Additional Notes

• N/A

Quality Checks

• At least one new test has been written for new code
• New code has 100% test coverage
• Code has been formatted with Black
• Code has been linted with flake8
• Docstrings for new methods have been added
• The documentation has been updated appropriately

[coveralls]

coverage: 100.0%. remained the same
when pulling 33c9326 on terms_and_conditions_error
into 9b8ea21 on main.