This repository has been archived by the owner on Apr 3, 2023. It is now read-only.
Use unnamed entry for project name when there is no package to infer from #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vitalybu
approved these changes
Jul 15, 2020
…to infer from.
It's is not mandatory to place classes in a package, not under src > main neither under src > test.
If this is the case, infer logic using getPackageName() method on Class objects, will get an empty string that will be used for project name when opening a development session with the Agent.
This will result in a missing information for report creation and session will be initialized without reporting responding to SDK with 202 HTTP status. Any further reporting commands will result in error 406.
Added logic to use the unnamed entry ('Unnamed Project') as project name when there is no package wrapping the class.
Signed-off-by: Marat Strelets <marat@testproject.io>
|
Copied PR description to the commit message. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's is not mandatory to place classes in a package, not under
src > mainneither undersrc > test.If this is the case, infer logic using
getPackageName()method onClassobjects, will get an empty string that will be used for project name when opening a development session with the Agent.This will result in a missing information for report creation and session will be initialized without reporting responding to SDK with 202 HTTP status. Any further reporting commands will result in error 406.
Added logic to use the unnamed entry (
Unnamed Project) as project name when there is no package wrapping the class.