Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TestNG codemining cause a NPE in code mining chain #496

Closed
gayanper opened this issue May 5, 2020 · 2 comments
Closed

TestNG codemining cause a NPE in code mining chain #496

gayanper opened this issue May 5, 2020 · 2 comments

Comments

@gayanper
Copy link
Contributor

gayanper commented May 5, 2020

For non tests classes the code mining provider for testng return null. This cause a break in the code mining chain. This is something we missed when implementing the codeminings in the initial stage.
@gayanper gayanper mentioned this issue May 5, 2020
Closed
missedone added a commit that referenced this issue May 5, 2020
@missedone
Merge pull request #497 from gayanper/master
0aaae7c 
Fix #496: return emptyList instead of null to avoid NPE.
@missedone
Copy link
Collaborator

hi @gayanper thanks for for the quick fix, it's released now: https://github.com/cbeust/testng-eclipse/releases/tag/7.2.0.202005051752

@gayanper
Copy link
Contributor Author

gayanper commented May 5, 2020

Thanks Nick

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@missedone @gayanper