Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(types): allow all elements #500

Closed
wants to merge 2 commits into from
Closed

fix(types): allow all elements #500

wants to merge 2 commits into from

Conversation

nickserv
Copy link
Member

@nickserv nickserv commented Nov 20, 2020

Port of testing-library/react-testing-library#833

Checklist:

  • Documentation
  • Tests
  • Typings
  • Ready to be merged

Copy link
Member

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kentcdodds
Copy link
Member

Not sure what's up with ci

@codecov
Copy link

codecov bot commented Nov 21, 2020

Codecov Report

Merging #500 (b7307e4) into master (f7620ab) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #500   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           13        13           
  Lines          615       615           
  Branches       200       200           
=========================================
  Hits           615       615           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f7620ab...b7307e4. Read the comment docs.

@nickserv
Copy link
Member Author

I fixed the build, but let's still wait to merge, I want to check something

@nickserv nickserv marked this pull request as draft November 21, 2020 02:17
@ph-fritsche
Copy link
Member

I'll close this for now as it is outdated. If you like to tackle this again please reopen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants