Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(release): trigger release #355

Merged
merged 1 commit into from
Apr 18, 2024
Merged

fix(release): trigger release #355

merged 1 commit into from
Apr 18, 2024

Conversation

yanick
Copy link
Collaborator

@yanick yanick commented Apr 18, 2024

:sigh: A chore doesn't bump up the version. This one should.

@yanick yanick merged commit cb9fc3a into main Apr 18, 2024
14 of 16 checks passed
Copy link

🎉 This PR is included in version 5.0.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@mcous
Copy link
Collaborator

mcous commented Apr 18, 2024

🤦

@yanick
Copy link
Collaborator Author

yanick commented Apr 18, 2024

🤦

Eventually, I'll get it right.

.... eventually.

@mcous
Copy link
Collaborator

mcous commented Apr 18, 2024

I like semantic-release in theory but at least in my short experience using it in this repo it's been nothing but sharp edges and footguns

@yanick
Copy link
Collaborator Author

yanick commented Apr 18, 2024

I like semantic-release in theory but at least in my short experience using it in this repo it's been nothing but sharp edges and footguns

:cover bandages with a blanket: I have no clue what you're talking about. ;-)

Of course, it doesn't help that we didn't set up the system ourselves, so discover a little bit its quirks as we go along. But yeah, I like my automations to give me a final "are you sure? [y/n]" before pulling the trigger. And I think that overall I prefer a system that creates a CHANGELOG file (like, say, https://github.com/changesets/changesets/tree/main#readme) over systems that rely on git messages (which initially sounds handy and elegant, but as soon as you want to edit something.. urgh)

@yanick yanick deleted the trigger-release branch April 18, 2024 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants