test(fireEvent): Add expected behavior for blur/focus in React #757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit f616c21:
|
Codecov Report
@@ Coverage Diff @@
## master #757 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 4 4
Lines 101 101
Branches 16 16
=========================================
Hits 101 101 Continue to review full report at Codecov.
|
2 tasks
|
🎉 This PR is included in version 10.4.8 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Add expected behavior for blur and focus bubbling in React. This is different than native DOM events where blur and focus do not bubble
Why:
Got messaged by core members that they might start listening to
focusin/focusoutinstead which would cause our currentfireEvent.focusimplementation to not register React focus events. We should also firefocusin/focusoutonce they start doing that (i.e.react@nextstarts breaking the build) which is similar to how we handlemouseEnter/mouseLeave.Ideally we'd get everybody on board to using
.focus()andblur()instead but that would only work withjsdom@16.3.0or a browser which is less than ideal.How:
Assert on invocation of event handlers for bubbled events
Checklist:
[ ] Documentation added to thedocs site
[ ] Typescript definitions updated