fix(fireEvent): Make sure react dispatches focus/blur events #758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 40fbff1:
|
eps1lon
changed the title
Codecov Report
@@ Coverage Diff @@
## master #758 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 4 4
Lines 101 109 +8
Branches 16 16
=========================================
+ Hits 101 109 +8
Continue to review full report at Codecov.
|
kentcdodds
approved these changes
Aug 5, 2020
|
🎉 This PR is included in version 10.4.8 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
This was referenced Sep 6, 2024
This was referenced Sep 14, 2024
This was referenced Sep 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Fix failing tests for
react@experimentalWhy:
react@experimental: In casenextis not released alongsideexperimental(such is the case right now). We don't support any experimental API right now but setting up infra before actual feature work makes feature work more approachable.How:
react@experimental(in addition tonextandlatest)Switch from
REACT_NEXTenvironment flag toREACT_DISTenum which can hold a valid npm dist tag for react.focusinalongsidefocusandfocusoutalongsideblurwhich is similar to how we handlemouseEnter/mouseLeave.Ideally we'd get everybody on board to using
.focus()andblur()instead but that would only work withjsdom@16.3.0or a browser which is less than ideal.Checklist:
[ ] Documentation added to thedocs site
[ ] Typescript definitions updated