fix(prefer-find-by): handle different spacing correctly for autofix (#…

…472) * fix(prefer-find-by): stop prefer-find-by fixer to break code when no spaces before bracket * fix(prefer-find-by): use regex to add findByMethod Co-authored-by: Marat Dyatko <maratd@spotify.com> Co-authored-by: Mario Beltrán Alarcón <belco90@gmail.com>
testing-library · Sep 9, 2021 · 9624a44 · 9624a44
1 parent 08e40fc
commit 9624a44
Show file tree

Hide file tree

Showing 2 changed files with 33 additions and 4 deletions.
diff --git a/lib/rules/prefer-find-by.ts b/lib/rules/prefer-find-by.ts
@@ -464,10 +464,10 @@ export default createTestingLibraryRule<Options, MessageIds>({
               const textDestructuring = sourceCode.getText(
                 allVariableDeclarations
               );
-              const text = `${textDestructuring.substring(
-                0,
-                textDestructuring.length - 2
-              )}, ${findByMethod} }`;
+              const text = textDestructuring.replace(
+                /(\s*})$/,
+                `, ${findByMethod}$1`
+              );
               allFixes.push(fixer.replaceText(allVariableDeclarations, text));
             }
 

diff --git a/tests/lib/rules/prefer-find-by.test.ts b/tests/lib/rules/prefer-find-by.test.ts
@@ -457,6 +457,35 @@ ruleTester.run(RULE_NAME, rule, {
         })
       `,
     })),
+    ...createScenario((waitMethod: string, queryMethod: string) => ({
+      code: `
+        import {${waitMethod}} from '@testing-library/foo';
+        it('tests', async () => {
+          const {${queryMethod}} = render()
+          const submitButton = await ${waitMethod}(() => expect(${queryMethod}('foo', { name: 'baz' })).not.toBeNull())
+        })
+      `,
+      errors: [
+        {
+          messageId: 'preferFindBy',
+          data: {
+            queryVariant: getFindByQueryVariant(queryMethod),
+            queryMethod: queryMethod.split('By')[1],
+            prevQuery: queryMethod,
+            waitForMethodName: waitMethod,
+          },
+        },
+      ],
+      output: `
+        import {${waitMethod}} from '@testing-library/foo';
+        it('tests', async () => {
+          const {${queryMethod}, ${buildFindByMethod(queryMethod)}} = render()
+          const submitButton = await ${buildFindByMethod(
+            queryMethod
+          )}('foo', { name: 'baz' })
+        })
+      `,
+    })),
     ...createScenario((waitMethod: string, queryMethod: string) => ({
       code: `
         import {${waitMethod}} from '@testing-library/foo';