Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disconnect MutationObserver synchronously in wait-for #801

Merged
merged 4 commits into from
Nov 3, 2020
Merged

Disconnect MutationObserver synchronously in wait-for #801

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
af1bc5b
Disconnect MutationObserver synchronously in wait-for
romain-trotard Nov 1, 2020
d2b5137
Revert the pre-commit change to be able to commit
romain-trotard Nov 2, 2020
68c6c17
Remove legacy disconnect
romain-trotard Nov 2, 2020
a8dffff
Merge branch 'master' into rtr-mutation-observer-disconnect
kentcdodds Nov 2, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/wait-for.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,10 @@ function waitFor(

if (!usingFakeTimers) {
clearInterval(intervalId)
observer.disconnect()

// Call also the disconnect method on setImmediate for projects not using the MutationObersver implementation of jsdom.
// But using for example `@sheerun/mutationobserver-shim` which provokes infinite loop when being called immediately on `onDone` function
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine to me. I'm only concerned about the implications of calling disconnect twice. I guess it's fine, but I'm not sure it's worthwhile having code that is only around to support a shim that nobody should be using (because they should be using a modern version of jsdom or a real browser environment). Anyone want to argue against just removing the next line?

Copy link
Member

@marcosvega91 marcosvega91 Nov 2, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have commented and on the issue and proposing two solutions:

Copy link
Contributor Author

@romain-trotard romain-trotard Nov 2, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If nobody should use shim, it's good for me to remove it.
Thank you Kent and Marco, I'm gonna remove it asap

Does someone know what I should do for the breaking CI ? (if there is something I can do)

setImmediate(() => observer.disconnect())
}

Expand Down