refactor: export label helpers to his own file and use both in suggestions and query

[marcosvega91]

What: Moved label helpers to his own file

Why: suggestions was using his logic to get label content that was not working with aria-labelledby

How: Using the logic implemented by @delca85 both for suggestions and label query

Checklist:

• Documentation added to the
  docs site
• Tests
• Typescript definitions updated
• Ready to be merged
  

[codesandbox-ci]

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 08d619a:

Sandbox	Source
kentcdodds/react-testing-library-examples	Configuration

[codecov]

Codecov Report

Merging #790 into master will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master      #790   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           25        26    +1     
  Lines          724       719    -5     
  Branches       190       184    -6     
=========================================
- Hits           724       719    -5     

Impacted Files	Coverage Δ
src/label-helpers.js	100.00% <100.00%> (ø)
src/queries/label-text.js	100.00% <100.00%> (ø)
src/suggestions.js	100.00% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a386d87...08d619a. Read the comment docs.

[kentcdodds]

Looks pretty good. Just one thing.

[kentcdodds]

Ok, I think it looks good to me. I'd love another reviewer here though. @delca85?

[delca85]

Ok, I think it looks good to me. I'd love another reviewer here though. @delca85?

I will be happy to review it but I am going to look at it in a couple of hours, ok?

[marcosvega91]

Is not a problem ☺️ thanks for the help @delca85

[delca85]

I approved this one. I think using the same logic in both suggestion and get labels logic is really a good idea! As well as fixing the suggestion defect related to label concatenation, for sure.

[kentcdodds]

Looks like @marcosvega91's other PR made a conflict with this one. Could you get that fixed @marcosvega91? Thanks!

[marcosvega91]

I have rebased the branch 👍 :)

[kentcdodds]

Excellent. Thank you!

[testing-library-bot]

🎉 This PR is included in version 7.26.4 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀