Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(contributing): Update checklist concerning types #358

Merged
merged 1 commit into from
Sep 23, 2019
Merged

docs(contributing): Update checklist concerning types #358

merged 1 commit into from
Sep 23, 2019

Conversation

eps1lon
Copy link
Member

@eps1lon eps1lon commented Sep 21, 2019

Types are as of #337 located in the DT repo. PRs have to be prepared and filed once the change in question is released.

kentcdodds
kentcdodds approved these changes Sep 23, 2019
View reviewed changes
Copy link
Member

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kentcdodds kentcdodds merged commit 2cd7b19 into testing-library:master Sep 23, 2019
@kentcdodds
Copy link
Member

@all-contributors please add @eps1lon for docs

@allcontributors allcontributors bot mentioned this pull request Sep 23, 2019
Merged
@allcontributors
Copy link
Contributor

@kentcdodds

I've put up a pull request to add @eps1lon! 🎉

@eps1lon eps1lon deleted the chore/contrib-types branch September 23, 2019 18:18
@kentcdodds
Copy link
Member

🎉 This PR is included in version 6.4.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kentcdodds kentcdodds kentcdodds approved these changes

Assignees
No one assigned
Labels
released TypeScript
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eps1lon @kentcdodds