Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: pin browserslist deps #1243

Merged

Conversation

jlp-craigmorten
Copy link
Contributor

@jlp-craigmorten jlp-craigmorten commented Jun 26, 2023

What:

Pin browserslist and caniuse-lite development dependencies.

Fixes #1242

Why:

There has been minor release of browserslist packages that remove support of op_mob 64 which this library currently makes use of. Updates to the support matrix are considered a breaking change, so by pinning dependencies we can unblock minor and patch changes while pending a major release to update these dependencies and the version support for opera mobile.

How:

Added browsers@4.21.8 and caniuse-lite@1.0.30001502 to the package.json overrides object (for Node >=16) and devDependencies (for Node 14).

Versions chosen to align with those used in the last commit to main on 14 June 2023.

Checklist:

- [ ] Documentation added to the
docs site
- [ ] Tests
- [ ] TypeScript definitions updated

  • Ready to be merged

@jlp-craigmorten
Copy link
Contributor Author

jlp-craigmorten commented Jun 26, 2023

Hmm, it seems overrides was introduced in Node 16 so isn't enough for Node 14.

Short of introducing a lockfile of sorts, best can try is define an explicit dev dependency... this I suspect will work because we don't have a lockfile and so long as no transient dependencies require a range higher than what we set npm will use our defined version. But this is fragile to breaking if any sub dependencies do rev their package.json range for either of the two packages. Node 16+ is fine.

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jun 26, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit d5c17a8:

Sandbox Source
react-testing-library-examples Configuration
react-testing-library demo Issue #1242

@codecov
Copy link

codecov bot commented Jun 27, 2023

Codecov Report

Merging #1243 (d5c17a8) into main (491e930) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##              main     #1243   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           24        24           
  Lines         1038      1038           
  Branches       349       346    -3     
=========================================
  Hits          1038      1038           
Flag Coverage Δ
node-14 100.00% <ø> (ø)
node-16 100.00% <ø> (ø)
node-18 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@eps1lon eps1lon merged commit 069e184 into testing-library:main Jun 27, 2023
7 of 10 checks passed
@jlp-craigmorten jlp-craigmorten deleted the chore/pin-browserslist-deps branch June 27, 2023 21:27
@MatanBobi
Copy link
Member

@all-contributors please add @jlp-craigmorten for code :)

@allcontributors
Copy link
Contributor

@MatanBobi

I've put up a pull request to add @jlp-craigmorten! 🎉

eps1lon pushed a commit to eps1lon/web-testing-library that referenced this pull request Oct 3, 2023
eps1lon pushed a commit to eps1lon/web-testing-library that referenced this pull request Oct 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI failing with op_mob browserslist error
3 participants