-
Notifications
You must be signed in to change notification settings - Fork 470
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
getByRole('meter')
doesn't find meter
element
#1171
Comments
Hi @idanen! Where did you see that it does? Remember that |
Oh.. Actually I followed Chrome's behavior in its accessibility tab, which shows a role of |
Yeah, sorry about that :) |
Maybe we should re-open this issue? Looks like the spec now specifies that meter is an implicit role. https://www.w3.org/TR/html-aria/ |
Uh oh! @Blacktiger, the image you shared is missing helpful alt text. Check #1171 (comment). Alt text is an invisible description that helps screen readers describe images to blind or low-vision users. If you are using markdown to display images, add your alt text inside the brackets of the markdown image. Learn more about alt text at Basic writing and formatting syntax: images on GitHub Docs. |
Thanks @Blacktiger! |
For now we just used a data-testid, but I'll definitely want to get our version upgraded when you guys do the final release. We really like how testing-library works and have been very happy with it, so thanks for all the work you guys have done on it. |
🎉 This issue has been resolved in version 10.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
@testing-library/dom
version: ^8.17.0Relevant code or config:
What you did:
Tried to fetch by (implicit) meter role
What happened:
Failed to get element
Reproduction:
https://codesandbox.io/s/react-testing-library-getbyrole-meter-forked-ziqc09
Problem description:
Should be able to fetch a
meter
element by implicit roleSuggested solution:
The text was updated successfully, but these errors were encountered: