fix: correct peer dependencies

[timdeschryver]

Closes #270

[the-ult]

Hey @timdeschryver

How did this resolve the dependencies issue?

I refactored the angular.json to workspace.json and using the per project configuration with project.json

https://blog.nrwl.io/per-project-configuration-storybook-support-for-angular-12-auto-refresh-for-dependency-graph-and-bcd2d1e06658

Atm angular-testing-library has both a angular.json and a workspace.json

Seems like you did a revert?

When building testing-library from within my old upgrade-to-angular-13 branche. I see that @angular/forms is somehow included

Which is weird. (unless it is used in testing-library somewhere?)
Nx generates the package.json based on the dependencies. It adds the missing dependencies.

projects/testing-library/package.json

  "peerDependencies": {
    "@angular/common": ">= 13.0.0",
    "@angular/platform-browser": ">= 13.0.0",
    "@angular/animations": ">= 13.0.0",  // ! this shouldn't be here either
    "@angular/router": ">= 13.0.0",
    "@angular/core": ">= 13.0.0"
  },
  "dependencies": {
    "@testing-library/dom": "^8.0.0",
    "tslib": "^2.0.0"
  },

dist/@testing-library/angular/package.json

"peerDependencies": {
    "@angular/common": ">= 13.0.0",
    "@angular/platform-browser": ">= 13.0.0",
    "@angular/animations": ">= 13.0.0",
    "@angular/router": ">= 13.0.0",
    "@angular/core": ">= 13.0.0",
    "@angular/forms": "13.0.2",  // added bij NX
    "rxjs": "^7.4.0",
    "@testing-library/user-event": "^13.5.0" // added by NX
  },
  "dependencies": {
    "@testing-library/dom": "^8.0.0",
    "tslib": "^2.0.0"
  },

angular/forms

As you can see @angular/forms is used by the tests. And somehow NX thinks @angular/forms is needed for the library as well.

FIX

Adding the @angular/forms as devDependencies to the project resolves this.
(and the same with @testing-library/user-event)

Question
Does testing-library-angular need any @angular/.. lib
as peerDependency? Or are they only used for the example app or tests?

A search gives these results:

Which would mean only these are needed as peerDependencies in projects/testing-library/package.json and also only as dependencies in the root package.json.

    "@angular/common": ">= 13.0.0",
    "@angular/platform-browser": ">= 13.0.0",
    "@angular/router": ">= 13.0.0",
    "@angular/core": ">= 13.0.0"

All other @angular/.. dependencies should/could be added to the devDependencies .. ??

[the-ult]

I could create a new PR with the new fixes.
And still using the per project configuration etc..

[timdeschryver]

@the-ult I re-added the angular.json file as a quick fix. It's probably better to add them as a dev dependency, but I wasn't aware that that would be the proper fix. Another problem is that the build task in the angular file also includes some post-build scripts, which should also be added to the nx file.

[the-ult]

I 'll try to make a new PR next week.

Not sure if adding them to the devDependencies is the fix. But from the quick test, it seems to work and generate a proper package.json.

And thinking: dependencies should only include the dependencies you'll need for production it seems logical, not needing them for the testing-library

We could ask somebody from the nx team if the above is actually needed. Might be a bug in NX. They should probably skip imports/dependencies, which are only used in tests.

[timdeschryver]

@the-ult fyi, it seems like we already got the post-build steps covered - so the only problem are the dependencies.

https://github.com/testing-library/angular-testing-library/blob/main/projects/testing-library/project.json#L38

[the-ult]

Indeed.
I'll try and create a PR tomorrow 👍

[timdeschryver]

No rush though @the-ult