Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

broken <ATL>/jest-utils module resolution in Jest v28 #299

Closed
dzonatan opened this issue Jun 9, 2022 · 1 comment · Fixed by #300
Closed

broken <ATL>/jest-utils module resolution in Jest v28 #299

dzonatan opened this issue Jun 9, 2022 · 1 comment · Fixed by #300
Labels
released

Comments

@dzonatan
Copy link
Contributor

dzonatan commented Jun 9, 2022

follow-up on jestjs/jest#12927

TLDR: @testing-library/angular/jest-utils import in Jest v28 is broken and results in this error:
image

Based on Simen's comment it seems like this library uses a bad package format:

@testing-library/angular needs to add an entry for it in exports.

Which is probably true because other packages like @angular/core/testing are following this format. There is even a comment about this in the Angular package format: https://angular.io/guide/angular-package-format#entrypoints-and-code-splitting

Just some comparison images of @angular/core/testing which works, and @testing-library/angular/jest-utils which doesn't.

@angular/core/testing
image

@testing-library/angular/jest-utils
image
@dzonatan dzonatan changed the title broken @testing-library/angular/jest-utils module resolution in Jest v28 broken <ATL>/jest-utils module resolution in Jest v28 Jun 9, 2022
dzonatan added a commit to dzonatan/angular-testing-library that referenced this issue Jun 9, 2022
@dzonatan
fix: use official secondary package format
1e6a3f6 
this fixes the `@testing-library/angular/spec-utils` import in Jest v28
closes testing-library#299
@dzonatan dzonatan mentioned this issue Jun 9, 2022
Merged
timdeschryver pushed a commit that referenced this issue Jun 10, 2022
@dzonatan
fix(jest-utils): use official secondary package format (#300)
0db3a5c 
Closes #299
@github-actions
Copy link

🎉 This issue has been resolved in version 12.0.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: use official secondary package format dzonatan/angular-testing-library
1 participant
@dzonatan