Fix: component setter is overwritten when component properties are set #192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@timdeschryver when do you think we can have a patch? |
|
In a few seconds, it's being released as we speak 😉 |
|
🎉 This PR is included in version 10.4.2 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
|
@all-contributors please add @GlebIrovich for code, tests |
|
I've put up a pull request to add @GlebIrovich! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is meant to fix an issue mentioned here.
The problem was that
definePropertywould overwrite original setter.Solution is to first retrieve that original setter and make sure it's invoked.